Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a script to convert a folder of images to a small .gif #1275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added a script to convert a folder of images to a small .gif #1275

wants to merge 1 commit into from
+127 −0

Conversation

sha016
Copy link

@sha016 sha016 commented Oct 26, 2021

Description

A python script that converts a folder of images to a .gif file. Provides a free and more private alternative to third party services such as giphy.

Fixes #(issue_no)

Fixes #1274

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

@ghost
Copy link

ghost commented Oct 26, 2021 •
edited by ghost
Loading

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

@sha016
Copy link
Author

sha016 commented Oct 30, 2021

@HarshCasper any comments? Thanks in advance

HarshCasper
HarshCasper requested changes Nov 10, 2021
View reviewed changes
Copy link
Owner

@HarshCasper HarshCasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Round (1)

Python/Images_to_GIF/README.md Outdated
@@ -0,0 +1,22 @@
# images_to_gif.py
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a line break

Python/Images_to_GIF/README.md Outdated
@@ -0,0 +1,22 @@
# images_to_gif.py
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give a proper title

Python/Images_to_GIF/README.md Outdated
# images_to_gif.py
A simple Python script that takes a directory of images, resizes them, and combines them into a .gif file.

## How to use
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give a line break

Python/Images_to_GIF/README.md Outdated
A simple Python script that takes a directory of images, resizes them, and combines them into a .gif file.

## How to use
python images_to_gif.py /fullpath/to/image/folder
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put backticks

Python/Images_to_GIF/README.md Outdated
## How to use
python images_to_gif.py /fullpath/to/image/folder

## Also this will work
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a line break

Python/Images_to_GIF/README.md Outdated
python images_to_gif.py /fullpath/to/image/folder

## Also this will work
python images_to_gif.py
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put backticks

Python/Images_to_GIF/README.md Outdated
Comment on lines 11 to 15
## requirements
imageio
Pillow

Pillow is a PIL fork.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is not needed. Add an instruction to download all dependencies using requirements.txt

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @HarshCasper , I believe the README conforms to the style guidelines now.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HarshCasper can this be merged now? better late than never :)

@HarshCasper HarshCasper added PR:Reviewed PRs that have been reviewed. and removed PR:Ready-to-Review labels Nov 10, 2021
@sha016 sha016 force-pushed the images-to-gif-converter branch from ef15b96 to 91e8a63 Compare November 10, 2021 19:19
@sha016 sha016 force-pushed the images-to-gif-converter branch from 91e8a63 to 25317b3 Compare November 10, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshCasper HarshCasper Awaiting requested review from HarshCasper

@ClasherKasten ClasherKasten Awaiting requested review from ClasherKasten

@sohamsshah sohamsshah Awaiting requested review from sohamsshah

Assignees
No one assigned
Labels
PR:Ready-to-Review PR:Reviewed PRs that have been reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[script request]: Script that takes a directory of photos and creates a small .gif from it
2 participants
@sha016 @HarshCasper