Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git contributors page #179

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Add git contributors page #179

merged 2 commits into from
Oct 17, 2024

Conversation

shubhagarwal1
Copy link
Contributor

@shubhagarwal1 shubhagarwal1 commented Oct 16, 2024

fix: #155
Screenshot 2024-10-17 at 2 46 55 AM

Copy link
Owner

@Harshdev098 Harshdev098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add the git Contributors link in the index.html just discard these changes in the index.html file, I will add it somewhere. Also edit the github link in the gitContributors.html file its refering to your forked repo

@shubhagarwal1
Copy link
Contributor Author

Don't add the git Contributors link in the index.html just discard these changes in the index.html file, I will add it somewhere. Also edit the github link in the gitContributors.html file its refering to your forked repo

understood making changes

@shubhagarwal1
Copy link
Contributor Author

@Harshdev098
done the changes
reverted the index file
added correct git link

@Harshdev098
Copy link
Owner

@shubhagarwal1 You have closed this, are you going to create new pr for it

@shubhagarwal1 shubhagarwal1 reopened this Oct 17, 2024
@shubhagarwal1
Copy link
Contributor Author

@shubhagarwal1 You have closed this, are you going to create new pr for it

@Harshdev098 mistakenly i did that, reopened the PR

@Harshdev098
Copy link
Owner

@shubhagarwal1 The changes are not visible its showing same link for github(your forked repository)

@shubhagarwal1
Copy link
Contributor Author

@Harshdev098 t
Uploading Screenshot 2024-10-18 at 12.45.01 AM.png…

@shubhagarwal1
Copy link
Contributor Author

@Harshdev098
Screenshot 2024-10-18 at 12 45 01 AM

@Harshdev098 Harshdev098 merged commit 8a4e24b into Harshdev098:main Oct 17, 2024
2 checks passed
@Harshdev098 Harshdev098 added hacktoberfest This issue belongs to hacktoberfest gssoc-ext This issue is under GSSoc Ext program level3 labe3 label for gssoc hacktoberfest-accepted label for accepted PRs under hacktoberfest labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext This issue is under GSSoc Ext program hacktoberfest This issue belongs to hacktoberfest hacktoberfest-accepted label for accepted PRs under hacktoberfest level3 labe3 label for gssoc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADD Dedicated Page for Gihub Contributors
2 participants