Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨the multi language support has been added to all the pages.✨ #187

Merged
merged 8 commits into from
Oct 18, 2024
Merged

✨the multi language support has been added to all the pages.✨ #187

merged 8 commits into from
Oct 18, 2024
+246 −5

Conversation

T-Rahul-prabhu-38
Copy link
Contributor

@T-Rahul-prabhu-38 T-Rahul-prabhu-38 commented Oct 17, 2024 •
edited
Loading

@Harshdev098 can you please review this , thank you
#152 solved.

Screen.Recording.2024-10-17.at.6.52.40.PM.mov

@T-Rahul-prabhu-38
Copy link
Contributor Author

T-Rahul-prabhu-38 commented Oct 17, 2024 •
edited
Loading

@Harshdev098 can you reveiw this PR.

@T-Rahul-prabhu-38
Copy link
Contributor Author

sure np

Harshdev098
Harshdev098 requested changes Oct 17, 2024
View reviewed changes
Copy link
Owner

@Harshdev098 Harshdev098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

increase the size of gtranslate_wrapper on every page somthing liike thenavbar fontsize, the visibility is very low

image

image

@T-Rahul-prabhu-38
Copy link
Contributor Author

ok ill make it appear as a button.

@T-Rahul-prabhu-38
Copy link
Contributor Author

@Harshdev098 the issue is fixed.
Screenshot 2024-10-17 at 11 59 10 PM

@T-Rahul-prabhu-38
Copy link
Contributor Author

T-Rahul-prabhu-38 commented Oct 17, 2024 •
edited
Loading

@Harshdev098 can you review this please.

@Harshdev098
Copy link
Owner

Harshdev098 commented Oct 17, 2024 •
edited
Loading

@T-Rahul-prabhu-38 You have changed the layout position of the navbar elements I just told you to increase the font-size of it don't add color or anything else

image

@T-Rahul-prabhu-38
Copy link
Contributor Author

ohh , ill fix that

@T-Rahul-prabhu-38
Copy link
Contributor Author

@Harshdev098 i have fixed it.
Screenshot 2024-10-18 at 9 53 15 AM

@T-Rahul-prabhu-38
Copy link
Contributor Author

@Harshdev098 can you please review this , thank you.

@Harshdev098 Harshdev098 merged commit 561e7d9 into Harshdev098:main Oct 18, 2024
1 check passed
@Harshdev098 Harshdev098 added hacktoberfest This issue belongs to hacktoberfest gssoc-ext This issue is under GSSoc Ext program level3 labe3 label for gssoc hacktoberfest-accepted label for accepted PRs under hacktoberfest labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harshdev098 Harshdev098 Harshdev098 requested changes

Assignees
No one assigned
Labels
gssoc-ext This issue is under GSSoc Ext program hacktoberfest This issue belongs to hacktoberfest hacktoberfest-accepted label for accepted PRs under hacktoberfest level3 labe3 label for gssoc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@T-Rahul-prabhu-38 @Harshdev098