Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GHA with new CDN S3 bucket DWOPS-629 #15

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Update GHA with new CDN S3 bucket DWOPS-629 #15

merged 2 commits into from
Nov 8, 2023

Conversation

lsutherl
Copy link

Description

This updates the path and access keys for the AWS S3 bucket used by GitHub Actions.

Requirements

Branches:

  1. DWOPS-629

Test Steps

  1. Push a test PR to this repo.
  2. The GitHub action should succeed.
  3. Do a code release.
  4. The GitHub action should succeed.

@nicholsonjf
Copy link

nicholsonjf commented Oct 31, 2023

*Edit: it looks like this answer, or one of the other suggestions from this page could work: https://stackoverflow.com/a/69802307

I tried to figure out why this was failing but never found anything conclusive. I did notice package-lock.json is installing v5.4 of WebPack but the "scripts" section in package.json seems to be using the v6 syntax:

https://laravel-mix.com/docs/5.0/installation#npm-scripts

Screenshot 2023-10-31 at 11 30 08 AM

@nicholsonjf nicholsonjf self-assigned this Oct 31, 2023
@lsutherl
Copy link
Author

lsutherl commented Nov 6, 2023

I ran npm install and npm update locally to catch the package-lock.son up.

Copy link

@nicholsonjf nicholsonjf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I see the check is passing now. I am still seeing the two deprecation warnings, but I'll leave that up to you whether or not to address now. Approved.

@lsutherl lsutherl merged commit 010b3eb into main Nov 8, 2023
1 check passed
@lsutherl lsutherl deleted the DWOPS-629 branch November 8, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants