Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2P Multiprocess [POC] #1138

Closed
wants to merge 1 commit into from
Closed

P2P Multiprocess [POC] #1138

wants to merge 1 commit into from

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Sep 27, 2024

This PR contains the POC for the P2P Multiprocess project. For more information, read the RFC.

@glevco glevco self-assigned this Sep 27, 2024
@glevco glevco marked this pull request as ready for review September 27, 2024 15:15
Copy link

github-actions bot commented Sep 27, 2024

🐰 Bencher Report

Branchfeat/p2p-mp-poc
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Lower Boundary
nanoseconds (ns)
(Limit %)
Upper Boundary
nanoseconds (ns)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
101,443,460,173.98
(-0.57%)
91,824,003,534.49
(90.52%)
112,229,337,653.26
(90.39%)
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 47.67932% with 124 lines in your changes missing coverage. Please review.

Project coverage is 84.03%. Comparing base (9fddd7a) to head (fe7e9a6).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
hathor/multiprocess/ipc.py 39.81% 65 Missing ⚠️
hathor/p2p_mp_poc.py 55.05% 40 Missing ⚠️
hathor/current_p2p.py 52.50% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1138      +/-   ##
==========================================
- Coverage   84.42%   84.03%   -0.40%     
==========================================
  Files         317      320       +3     
  Lines       24291    24528     +237     
  Branches     3696     3705       +9     
==========================================
+ Hits        20507    20611     +104     
- Misses       3068     3197     +129     
- Partials      716      720       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco
Copy link
Contributor Author

glevco commented Oct 17, 2024

Closing this in favor of #1161.

@glevco glevco closed this Oct 17, 2024
@glevco glevco deleted the feat/p2p-mp-poc branch October 17, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant