refactor(p2p): implement initial state [part 8/11] #1172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1142
Motivation
This PR addresses a few architectural shortcomings in the handling of protocol states in P2P. Currently:
HathorProtocol.state
attribute isOptional
and starts asNone
, instead of having a well-defined initial state.PeerState
enum and theBaseState
subclasses themselves.HathorProtocol
instances after they get connected, but it's useful to track them since construction. Specifically, this will be necessary for the P2P Multiprocess project.Acceptance Criteria
InitialState
and changeHathorProtocol.state
to be non-nullable.PeerState
.built_protocol_callback
on P2P protocol factory and use it to track built protocol instances inPeerConnections
.PeerAddress.__hash__
override to consider localhost.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged