Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: miscellaneous minor refactors [part 11/11] #1175

Open
wants to merge 1 commit into
base: feat/subprocess-protocol
Choose a base branch
from

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Nov 7, 2024

Depends on #1167

Motivation

Implement some small refactors as part of the P2P Multiprocess project.

Acceptance Criteria

  • Refactor the TransactionCacheStorage initialization so it handles default interval and capacity values by itself, instead of the CliBuilder doing it.
  • Fix ConnectOnSubprocess so it correctly configures logging in the subprocess.
  • Update PeerConnections to use P2PConnectionProtocol instead of HathorProtocol and other minor typing adjustments.
  • Update rocksdb bindings, adding support for open as secondary db.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco added the refactor label Nov 7, 2024
@glevco glevco self-assigned this Nov 7, 2024
@glevco glevco force-pushed the refactor/p2p/misc branch 3 times, most recently from db86b1f to 8a2431f Compare November 7, 2024 14:34
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 14 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat/subprocess-protocol@e761796). Learn more about missing BASE report.

Files with missing lines Patch % Lines
hathor/multiprocess/subprocess_runner.py 16.66% 5 Missing ⚠️
hathor/p2p/peer_connections.py 88.88% 3 Missing and 2 partials ⚠️
hathor/multiprocess/connect_on_subprocess.py 60.00% 2 Missing ⚠️
hathor/builder/cli_builder.py 85.71% 1 Missing ⚠️
hathor/p2p/dependencies/protocols.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##             feat/subprocess-protocol    #1175   +/-   ##
===========================================================
  Coverage                            ?   84.46%           
===========================================================
  Files                               ?      321           
  Lines                               ?    24712           
  Branches                            ?     3754           
===========================================================
  Hits                                ?    20874           
  Misses                              ?     3098           
  Partials                            ?      740           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the refactor/p2p/misc branch from 8a2431f to 09f1d09 Compare November 7, 2024 15:15
@glevco glevco changed the title refactor: miscellaneous minor refactors refactor: miscellaneous minor refactors [part 11/11] Nov 7, 2024
@glevco glevco marked this pull request as ready for review November 7, 2024 16:23
@glevco glevco force-pushed the feat/subprocess-protocol branch from aedf046 to e761796 Compare November 8, 2024 15:46
@glevco glevco force-pushed the refactor/p2p/misc branch from 09f1d09 to dcbee2a Compare November 8, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

1 participant