refactor: miscellaneous minor refactors [part 11/11] #1175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1167
Motivation
Implement some small refactors as part of the P2P Multiprocess project.
Acceptance Criteria
TransactionCacheStorage
initialization so it handles default interval and capacity values by itself, instead of theCliBuilder
doing it.ConnectOnSubprocess
so it correctly configures logging in the subprocess.PeerConnections
to useP2PConnectionProtocol
instead ofHathorProtocol
and other minor typing adjustments.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged