Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(indexes): remove sync-v1 indexes #1200

Open
wants to merge 1 commit into
base: feat/consensus-change
Choose a base branch
from

Conversation

jansegre
Copy link
Member

@jansegre jansegre commented Jan 8, 2025

Motivation

After removing sync-v1 (#1197) and removing block ties (#673) there is no need to have the sync-v1 indexes (tx-tips, block-tips and all-tips). There should be a slight runtime benefit (no measurement has been made), but more noticeably, there will be a substantial improvement in startup time.

Acceptance Criteria

  • Remove tx_tips, block_tips and all_tips indexes
  • Refactor relevant methods
  • Refactor tests

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre requested a review from msbrogli as a code owner January 8, 2025 16:38
@jansegre jansegre self-assigned this Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

🐰 Bencher Report

Branchfeat/remove-sync-v1-indexes
Testbedubuntu-22.04

🚨 1 Alert

BenchmarkMeasure
Units
ViewBenchmark Result
(Result Δ%)
Lower Boundary
(Limit %)
sync-v2 (up to 20000 blocks)Latency
minutes (m)
📈 plot
🚨 alert (🔔)
🚷 threshold
1.42
(-14.30%)
1.49
(105.02%)
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚨 view alert (🔔)
🚷 view threshold
1.42
(-14.30%)
1.49
(105.02%)
1.82
(77.91%)
🐰 View full continuous benchmarking report in Bencher

@jansegre jansegre changed the base branch from master to feat/consensus-change January 24, 2025 16:15
@jansegre jansegre force-pushed the feat/remove-sync-v1-indexes branch from b6bdf57 to 0e6013a Compare January 24, 2025 16:19
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 92.63158% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.55%. Comparing base (ea7d72c) to head (cbfd6f1).

Files with missing lines Patch % Lines
hathor/manager.py 92.10% 2 Missing and 1 partial ⚠️
hathor/simulator/fake_connection.py 0.00% 2 Missing ⚠️
hathor/transaction/resources/mempool.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           feat/consensus-change    #1200      +/-   ##
=========================================================
- Coverage                  83.57%   83.55%   -0.03%     
=========================================================
  Files                        320      317       -3     
  Lines                      24534    24222     -312     
  Branches                    3756     3699      -57     
=========================================================
- Hits                       20504    20238     -266     
+ Misses                      3266     3232      -34     
+ Partials                     764      752      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansegre jansegre force-pushed the feat/remove-sync-v1-indexes branch from 0e6013a to 752b56a Compare January 24, 2025 16:38
@jansegre jansegre force-pushed the feat/consensus-change branch from 0a38b06 to ea7d72c Compare January 24, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress (Done)
Development

Successfully merging this pull request may close these issues.

1 participant