Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): regression on run_node --help #1220

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

jansegre
Copy link
Member

@jansegre jansegre commented Feb 5, 2025

Motivation

Doing python -m hathor run_node --help broke in some cases due to a bug in some versions of argparse.

Acceptance Criteria

  • Remove all mutually exclusive groups where all arguments have help=SUPRESS, but keep the arguments in the base parser
  • Add a test that runs the CLI's help and have a basic sanity check (exit code 0 and at least 80 lines)

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre requested review from msbrogli and glevco February 5, 2025 17:31
@jansegre jansegre self-assigned this Feb 5, 2025
msbrogli
msbrogli previously approved these changes Feb 5, 2025
Copy link

github-actions bot commented Feb 5, 2025

🐰 Bencher Report

Branchfix/cli-help-regression
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.47
(-9.82%)
1.47
(99.80%)
1.80
(81.98%)
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.39%. Comparing base (05f1958) to head (314f6ad).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1220      +/-   ##
==========================================
+ Coverage   84.36%   84.39%   +0.03%     
==========================================
  Files         320      320              
  Lines       24568    24564       -4     
  Branches     3768     3762       -6     
==========================================
+ Hits        20726    20732       +6     
+ Misses       3097     3091       -6     
+ Partials      745      741       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansegre jansegre force-pushed the fix/cli-help-regression branch from af6f9da to 314f6ad Compare February 6, 2025 15:49
@jansegre jansegre merged commit 22ab6a8 into master Feb 6, 2025
10 checks passed
@jansegre jansegre deleted the fix/cli-help-regression branch February 6, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting to be deployed
Development

Successfully merging this pull request may close these issues.

3 participants