-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: fix promise left hanging after unit tests finish #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #306 +/- ##
=======================================
Coverage 86.98% 86.98%
=======================================
Files 35 35
Lines 1352 1352
Branches 269 269
=======================================
Hits 1176 1176
Misses 155 155
Partials 21 21 |
pedroferreira1
changed the title
tests: use detect open handles for the unit tests
tests: fix promise left hanging after unit tests finish
Jun 19, 2023
pedroferreira1
force-pushed
the
tests/unit-tests-hanging
branch
from
June 22, 2023 19:43
c935179
to
7a0d615
Compare
r4mmer
approved these changes
Jun 22, 2023
tuliomir
approved these changes
Jun 23, 2023
pedroferreira1
force-pushed
the
tests/unit-tests-hanging
branch
from
July 4, 2023 01:36
652c02a
to
574cbfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Issue: #292
The following log was found during unit tests
Checking this issue one of the possibilities was that the supertest server was not being closed after the test.
I used the solution proposed here
Acceptance Criteria
forceExit
parameter for a while to understand if there could be other hanging places.Security Checklist