tests: wait for multisig tx to arrive before continuing the test

[pedroferreira1]

Issue: #292

Acceptance Criteria

• Wait multisig transaction before continuing test to prevent out of funds error

Security Checklist

• Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

[codecov]

Codecov Report

Merging #308 (0978338) into dev (4a8f508) will not change coverage.
The diff coverage is n/a.

❗ Current head 0978338 differs from pull request most recent head affaff7. Consider uploading reports for the commit affaff7 to get more accurate results

@@           Coverage Diff           @@
##              dev     #308   +/-   ##
=======================================
  Coverage   86.98%   86.98%           
=======================================
  Files          35       35           
  Lines        1352     1352           
  Branches      269      269           
=======================================
  Hits         1176     1176           
  Misses        155      155           
  Partials       21       21           

[tuliomir]

When a timeout is passed as parameter, I believe this while block will continue running even after a reject is sent. ( similar case on a SO question )

Since this is an util used only on the integration tests, the effects of these "leaks" will probably not be very impactful, but I think it's important to at least document this behavior, so that future improvements can target this easily.

[pedroferreira1]

From the SO answer I read this:

Unless an error is thrown, a function is executed until a return statement or its end is reached. Other code outside of the function can't interfere with that (unless, again, an error is thrown).

So if I just add the return reject it should be enough, right?

[pedroferreira1]

Actually, this is not enough because the return is ending the setTimeout block, I've done some tests here and double-checked it.

I've done the timeout handling a bit differently, what do you think? 0978338

[tuliomir]

I think that's a good solution 👍