(4) feat: Add title to HathorList and refactor Settings page #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabadesso
approved these changes
Oct 5, 2023
| @@ -101,7 +101,7 @@ export class Settings extends React.Component { | |||
| ) | |||
| )} | |||
|
|
|||
| <HathorList infinity> | |||
| <HathorList title={t`General Settings`}> | |||
There was a problem hiding this comment.
What was this infinity doing?
There was a problem hiding this comment.
It applies an "infinity style". In practice it prolongs the list frame to appear as it goes beyond the screen. But we don't want this style in the settings section anymore, because we will have 2 settings lists.
alexruzenhack
force-pushed
the
refactor/explorer-component
branch
from
35d685f to
ea5ecd8
Compare
alexruzenhack
force-pushed
the
refactor/ds-settings-page
branch
from
f360464 to
f6572ee
Compare
pedroferreira1
approved these changes
Oct 10, 2023
alexruzenhack
changed the title
alexruzenhack
force-pushed
the
refactor/explorer-component
branch
2 times, most recently
from
70858d2 to
f7fd7ae
Compare
andreabadesso
approved these changes
Oct 20, 2023
alexruzenhack
force-pushed
the
refactor/explorer-component
branch
from
f7fd7ae to
f1da4af
Compare
alexruzenhack
force-pushed
the
refactor/ds-settings-page
branch
from
f6572ee to
ebb8580
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following change is related to this "Settings page" topic in the design.
Acceptance Criteria
Security Checklist