Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(10) feat: add custom network settings screen #350

Merged
merged 11 commits into from
Oct 25, 2023
Merged

(10) feat: add custom network settings screen #350

merged 11 commits into from
Oct 25, 2023

Conversation

alexruzenhack
Copy link
Contributor

@alexruzenhack alexruzenhack commented Oct 10, 2023 •
edited
Loading

Acceptance Criteria

  • feat(wip): add CustomNetworkSettingsScreen
  • feat: add warning message container
  • feat: add feedback modals based on network settings status
ds-customform-rv1-clip.mp4

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@alexruzenhack alexruzenhack self-assigned this Oct 10, 2023
@alexruzenhack alexruzenhack changed the title feat: add custom network settings screen (10) feat: add custom network settings screen Oct 11, 2023
andreabadesso
andreabadesso requested changes Oct 11, 2023
View reviewed changes
src/sagas/networkSettings.js Outdated Show resolved Hide resolved
src/sagas/networkSettings.js Outdated Show resolved Hide resolved
@alexruzenhack alexruzenhack mentioned this pull request Oct 20, 2023
Open
9 tasks
@alexruzenhack alexruzenhack added the enhancement New feature or request label Oct 20, 2023
@alexruzenhack
Copy link
Contributor Author

There is a new video to illustrate the change.

@alexruzenhack alexruzenhack force-pushed the fix/ds-wallet-service-version branch from 924df17 to 7400d0e Compare October 20, 2023 21:15
@alexruzenhack alexruzenhack force-pushed the feat/ds-custom-settings branch from 34c9c18 to e0821c9 Compare October 20, 2023 21:18
@alexruzenhack
Copy link
Contributor Author

Rebased to resolve conflicts.

@alexruzenhack alexruzenhack force-pushed the fix/ds-wallet-service-version branch from 7400d0e to 42f6305 Compare October 25, 2023 22:36
Base automatically changed from fix/ds-wallet-service-version to dev October 25, 2023 22:39
@alexruzenhack alexruzenhack force-pushed the feat/ds-custom-settings branch from e0821c9 to 127fa1b Compare October 25, 2023 22:51
@alexruzenhack alexruzenhack merged commit e5ebad2 into dev Oct 25, 2023
3 checks passed
@alexruzenhack alexruzenhack deleted the feat/ds-custom-settings branch October 25, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreabadesso andreabadesso andreabadesso approved these changes

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

Assignees

@alexruzenhack alexruzenhack

Labels
enhancement New feature or request
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexruzenhack @pedroferreira1 @andreabadesso