Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DeployInstance script #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add DeployInstance script #2

wants to merge 3 commits into from

Conversation

spengrah
Copy link
Member

Adds a new deployment script for deploying module instances

Also bumps solc to 0.8.21

gershido
gershido approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@gershido gershido left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Only one comment on an unused SALT variable

script/Deploy.s.sol
/// @dev Deploy an instance of the implementation
contract DeployInstance is Deployer {
HatsModuleFactory public factory = HatsModuleFactory(0xfE661c01891172046feE16D3a57c3Cf456729efA);
bytes32 public SALT = bytes32(abi.encode("change this to the value of your choice"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in use here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gershido gershido gershido approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spengrah @gershido