Clip rect scale #2643
Open
Clip rect scale #2643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geokureli
commented
Jan 17, 2023
Comment on lines
+279
to
+284
| /** | ||
| * If true, clipRect will behave as it did in flixel 4 and earlier. | ||
| * Where the clipRect will scale up proportionally with the sprite. | ||
| * @since 5.0.0 | ||
| */ | ||
| public var clipRectIgnoreScale(default, set):Bool = false; |
There was a problem hiding this comment.
TODO:
- keep legacy behavior, make this an opt-in feature
- come up with a better name maybe
scaleClipRector something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2301
Example of old/new behavior: https://imgur.com/8CQBhDa
can toggle sprites to use the old behavior with
legacyClipRectMode