fix for html5 arrow keys not working on the console #3247
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2190 and #3233
on HTML5,
preventDefaultKeys
inFlxKeyboard
also callspreventDefault()
to the keyboard event. This is helpful for not tabbing or scrolling the page when arrow keys or tab is pressed, but side effect is that it cancels the event propegation from reaching our event listeners fully.This is a bit of a workaround for that, we directly call the event listener ourselves