Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify FlxGraphicShader #3327

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

Simplify FlxGraphicShader #3327

wants to merge 5 commits into from
+20 −17

Conversation

Geokureli
Copy link
Member

@Geokureli Geokureli commented Dec 30, 2024 •
edited
Loading

Addition to #3326

Another attempt at the other part of #3321

Simplifies FlxGraphicsShader and removes ifs for mix calls. Let's hope that's a good thing

To Dos

  • See if thats a good thing
  • Figure out how to profile shaders
  • Learn more about shader attributes and flixel's batch rendering

@Geokureli Geokureli added this to the Next Patch milestone Dec 30, 2024
@Geokureli Geokureli changed the title Camera color Simplify FlxGraphicShader Dec 31, 2024
@Geokureli Geokureli marked this pull request as draft January 2, 2025 15:05
@Geokureli
Copy link
Member Author

Geokureli commented Jan 2, 2025 •
edited
Loading

gonna shelf this until I learn why hasTransform is being set to false, in renaine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Performance/Memory Rendering
Projects
None yet
Milestone
Next Patch
Development

Successfully merging this pull request may close these issues.
1 participant
@Geokureli