Also extern typedef doesn't make much sense I think?

HaxeFoundation · Feb 5, 2024 · e8555b1 · e8555b1
1 parent 43e0b0c
commit e8555b1
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/src/core/ast.ml b/src/core/ast.ml
@@ -354,7 +354,6 @@ type abstract_flag =
 
 type typedef_flag =
 	| TDPrivate
-	| TDExtern
 
 type enum_constructor = {
 	ec_name : placed_name;

diff --git a/src/core/display/completionItem.ml b/src/core/display/completionItem.ml
@@ -130,7 +130,7 @@ module CompletionModuleType = struct
 				params = d.d_params;
 				meta = d.d_meta;
 				doc = d.d_doc;
-				is_extern = List.mem TDExtern d.d_flags;
+				is_extern = false;
 				is_final = false;
 				is_abstract = false;
 				kind = kind;

diff --git a/src/macro/macroApi.ml b/src/macro/macroApi.ml
@@ -1617,7 +1617,7 @@ let decode_type_def v =
 		in
 		EEnum (mk (if isExtern then [EExtern] else []) (List.map conv fields))
 	| 1, [] ->
-		ETypedef (mk (if isExtern then [TDExtern] else []) (CTAnonymous fields,pos))
+		ETypedef (mk [] (CTAnonymous fields,pos))
 	| 2, [ext;impl;interf;final;abstract] ->
 		let flags = if isExtern then [HExtern] else [] in
 		let is_interface = decode_opt_bool interf in
@@ -1636,7 +1636,7 @@ let decode_type_def v =
 		let flags = if is_abstract then HAbstract :: flags else flags in
 		EClass (mk flags fields)
 	| 3, [t] ->
-		ETypedef (mk (if isExtern then [TDExtern] else []) (decode_ctype t))
+		ETypedef (mk [] (decode_ctype t))
 	| 4, [tthis;tflags;tfrom;tto] ->
 		let flags = match opt decode_array tflags with
 			| None -> []

diff --git a/src/syntax/parser.ml b/src/syntax/parser.ml
@@ -233,8 +233,7 @@ let decl_flag_to_abstract_flag (flag,p) = match flag with
 
 let decl_flag_to_typedef_flag (flag,p) = match flag with
 	| DPrivate -> Some TDPrivate
-	| DExtern -> Some TDExtern
-	| DFinal | DMacro | DDynamic | DInline | DPublic | DStatic | DOverload -> unsupported_decl_flag_typedef flag p
+	| DExtern | DFinal | DMacro | DDynamic | DInline | DPublic | DStatic | DOverload -> unsupported_decl_flag_typedef flag p
 
 let decl_flag_to_module_field_flag (flag,p) = match flag with
 	| DPrivate -> Some (APrivate,p)