Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typer cleanup continued #11548

Merged
merged 19 commits into from
Feb 5, 2024
Merged

Typer cleanup continued #11548

merged 19 commits into from
Feb 5, 2024

Conversation

Simn
Copy link
Member

@Simn Simn commented Feb 5, 2024

  • a whole lot of moving code around to make internal dependencies nicer
  • server.ml now has no knowledge of typecore.ml anymore, which is better because it happens at "com level"
  • less ctx passing in places where we only need com (and sometimes g)
  • less mutability
  • child contexts are now asserted to have an equal or higher pass, which is a property that should allow us to clean up delay handling

Simn added 19 commits February 2, 2024 17:35
@Simn
remove @:enumConstructorParam
d21862a
@Simn
remove init_class_done
bf82b40 
see if this breaks anything
@Simn
clone for expr
ec8d6d0
@Simn
make ctx.pass immutable
2b2764a
@Simn
ctx.e can be immutable too
22d7f61
@Simn
add failing test to show everyone that it's broken
2e68e40
@Simn
fix it
adca629
@Simn
only need g for delays
b1c6087
@Simn
lose server dependency on typer
8022d4e
@Simn
evacuate some things from typecore.ml
8593636
@Simn
small cleanup
154cb5b
@Simn
Merge branch 'development' into more_typer_cleanup
8336545 
# Conflicts:
#	src/typing/macroContext.ml
@Simn
Merge branch 'more_typer_cleanup' into even_more_typer_cleanup
3ed7906
@Simn
add g.root_typer
9e0c7e4 
This gives us a nice context tree structure
@Simn
remove more { ctx with and assert order
d7e848a
@Simn
less mutability and cloning
491e0a7
@Simn
even less cloning
790af65
@Simn
Merge branch 'development' into even_more_typer_cleanup
f0ff06e 
# Conflicts:
#	src/context/typecore.ml
#	src/typing/macroContext.ml
#	src/typing/typeloadFields.ml
#	src/typing/typer.ml
@Simn
fix allow_inline again
9d5aa06
@Simn Simn merged commit a10790a into development Feb 5, 2024
122 checks passed
@Simn Simn deleted the even_more_typer_cleanup branch February 5, 2024 09:03
@skial skial mentioned this pull request Feb 6, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Simn @kLabz