-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hl] Rework Null<Int/Float/Bool> comparison for spec/alloc #11612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tests/runci/targets/Flash.hx
Oh Flash ! I'll remove the test file after CI run. Just to ensure that it works on HL. |
Maybe merge this with #8426 so we have the changes and tests in one place? |
I would like to, but as you can see in the CI of previous commit, the flash test fail. Should I make an exception for flash target? |
Yes we're not going to fix it for Flash. |
This reverts commit f82a51c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Null<Int/Float>
, first test with null (if null return false), then safecast and compare the value. For Some operator tests related toNull<T>
#8426Null<Int/Float/Bool>
withInt/Float/bool
, first test with null (if null return false), then safecast and compare, reduce the use of todyn (memory allocation). For Hashlink null comparison #11416common_type
with the use ofcommon_type_number
, so that the recursion is more cleareval_expr
usejump_expr
in case of comparison