Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hl] Rework Null<Int/Float/Bool> comparison for spec/alloc #11612

Merged
merged 13 commits into from
Mar 20, 2024

Conversation

yuxiaomao
Copy link
Contributor

  • When OpGt | OpGte | OpLt | OpLte Null<Int/Float>, first test with null (if null return false), then safecast and compare the value. For Some operator tests related to Null<T> #8426
  • When OpEq | OpNotEq Null<Int/Float/Bool> with Int/Float/bool, first test with null (if null return false), then safecast and compare, reduce the use of todyn (memory allocation). For Hashlink null comparison #11416
  • Remove recursion of common_type with the use of common_type_number, so that the recursion is more clear
  • Use the same comparison logic during jump and normal comparison: let eval_expr use jump_expr in case of comparison

@yuxiaomao
Copy link
Contributor Author

Oh Flash ! I'll remove the test file after CI run. Just to ensure that it works on HL.

@skial skial mentioned this pull request Mar 18, 2024
1 task
@Simn
Copy link
Member

Simn commented Mar 19, 2024

Maybe merge this with #8426 so we have the changes and tests in one place?

@yuxiaomao
Copy link
Contributor Author

I would like to, but as you can see in the CI of previous commit, the flash test fail. Should I make an exception for flash target?

@Simn
Copy link
Member

Simn commented Mar 20, 2024

Yes we're not going to fix it for Flash.

@Simn Simn merged commit 3b0c8f4 into HaxeFoundation:development Mar 20, 2024
50 checks passed
@yuxiaomao yuxiaomao deleted the dev-hlnull branch March 20, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants