[hxb] Ignore invalidations during display requests #11660
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of [hxb] Signature dependencies - part 2 #11659 for nowbinary_cache
incompilationCache.ml
)MSGood
during display requestsI tested this branch with all projects I had available, without detecting any issue (at least not any new issue) and got very promising results (see below).
Notes:
hxbit
letting it run its macros during display requests (but that's also true for other nightlies)[Shiro project]
5.0.0-alpha.1+c325889
:[Shiro project]
5.0.0-alpha.1+c325889
:[Shiro project]
5.0.0-alpha.1+c325889
:[Personal heaps game] (very similar results on other small[ish] scale projects)
5.0.0-alpha.1+c325889
:Other "small scale" projects
Smaller projects that tend to have no issues with Haxe 4 and are running diagnostics still have much faster display requests when cache has just been filled (after compilation or diagnostics), though even those can have slightly better timings (with diagnostics disabled at least) when files start to be invalidated.
Misc
5.0.0-alpha.1+c325889
and this branch ~15sec including 12+ seconds of macros and rest in typing; something is wrong on user code there