-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] add hlc test on Windows using MSBuild #11733
base: development
Are you sure you want to change the base?
Conversation
Good initiative! |
It's ready for review and we can rerun it if we need to check current haxe with hl/c on windows. I marked it as draft to prevent merge (until we decide to skip some test or fixed the bugs). Currently the result is
Additionally, I have tested on local with optimization disabled
|
What do you mean exactly? I would think that the next step would be to address the unit test failures one by one. |
Sorry, I wasn't clear. I mean the CI code here is complete for me (if we add fix to hlc, it's to hlc and not to the CI), it can be merged - after enable main.yml - if we decided to skip those failure and fix them another time. |
I have fixed some failures caused by Visual Studio's optimization (merging identical function) in the templates: HaxeFoundation/hashlink@9cf7efa Now there is only int shift overflow problems ("caused by"
|
With the last commit, it does not fail locally with Visual Studio GUI/MSBuild on both 2019 Community and 2022 Community, strange. |
This PR add hlc test on Windows. It depends on the template that I just added to hashlink: HaxeFoundation/hashlink@af63dba
WARNING: I disabled manually all workflow except windows64-test on hl, just to get a fast result, it uses nightly haxe. Need to revert it before merge: run
cd extra/github-actions && haxe build.hxml
, then push.github/workflows/main.yml
.It fail at some unit tests for now, should probably fix them some day.