Add MDynamic to late-bind monomorphs to Dynamic #11890
Merged
+28
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typer generally avoids binding monomorphs to Dynamic, which has been causing several issues. With this change, unification adds a
MDynamic
flag to the monomorph and then infersDynamic
if there has been no other unification by the time the monomorph is closed.This means that it's still a monomorph during typing, as we can see here:
However, the dump now shows
[Var b<0>(VUsedByTyper VAnalyzed):Dynamic]
, which confirms that the monomorph has been bound. This should always be preferable to having dangling open monomorphs, especially when they could appear in a function signature and could be inferred from the outside.This shouldn't break anything but there's always a chance some code somehow relied on this behavior. It would be good to do a brief check @yuxiaomao.