Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with _hx_new #12005

Merged
merged 7 commits into from
Feb 12, 2025
Merged

Deal with _hx_new #12005

merged 7 commits into from
Feb 12, 2025

Conversation

Simn
Copy link
Member

@Simn Simn commented Feb 12, 2025

3 steps if all goes well:

  1. Rename _new to _hx_new
  2. Add CfAbstractConstructor
  3. Add a_constructor

Closes #11994

@Simn
Copy link
Member Author

Simn commented Feb 12, 2025

There are now only 3 occurrences of the "_hx_new" string in the codebase:

  1. The one from the actual renaming.
  2. The one that checks the name for is_abstract_constructor. This could be replaced with some metadata but I don't think it's worth it.
  3. Some field_name case in inheritDoc.ml that I don't really understand, so I left it alone.

@kLabz
Copy link
Contributor

kLabz commented Feb 12, 2025

Checking what's wrong with CsSafeTypeBuilding here... 🤔

@kLabz
Copy link
Contributor

kLabz commented Feb 12, 2025

Checking what's wrong with CsSafeTypeBuilding here... 🤔

12 |  @:persistent static var generated = new Map<String, Bool>();
   |                                      ^^^^^^^^^^^^^^^^^^^^^^^
   | haxe.ds.Map does not have a constructor

Uh?

@Simn
Copy link
Member Author

Simn commented Feb 12, 2025

I was hoping that something would fail because I'm not dealing with the new a_constructor in the hxb reader yet. With any luck it's that.

@kLabz
Copy link
Contributor

kLabz commented Feb 12, 2025

Good thing this is done before preview, that way we don't have to bump hxb version 😁

@Simn Simn merged commit 6414bf8 into development Feb 12, 2025
115 checks passed
@Simn Simn deleted the _hx_new branch February 12, 2025 18:59
@skial skial mentioned this pull request Feb 13, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static extension with name _new resolving incorrectly to abstract new
2 participants