Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for VCS installs not actually checking the commit id of current branch #636

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Fix for VCS installs not actually checking the commit id of current branch #636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified run.n
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion src/haxelib/api/Installer.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,7 +791,7 @@ class Installer {
final wasUpdated = vcsBranchesByLibraryName.exists(library);
// difference between a key not having a value and the value being null

final currentBranch = vcsBranchesByLibraryName[library];
final currentBranch = vcsBranchesByLibraryName[library] ?? vcs.getReproducibleVersion(libPath).ref;

// TODO check different urls as well
if (branch != null && (!wasUpdated || currentBranch != branch)) {
Expand Down
Loading