Add support for null coalescing (?? & ??=)
#131
Conversation
hscript/Parser.hx
Outdated
| mk(ETernary( | ||
| mk(EBinop("==", mk(EIdent(tmp),pmin(e1),pmax(e1)), mk(EIdent("null"),pmin(e1),pmax(e1)))), | ||
| e2, | ||
| e1 |
There was a problem hiding this comment.
Shouldn't this be tmp to avoid code duplication?
There was a problem hiding this comment.
This also means that a relevant test is missing.
There was a problem hiding this comment.
i just made one and after the change runs successfully, but maybe pushing it would be a lot of code just for it that now works great. I had to make a new class with a integer variable with a getter function that increases everytime you access it
|
should be good now |
|
Is there any new about this? |
|
btw i just added support for |
gamerbross
changed the title
?? & ??=)
|
You should do "??" + "=" since the c++ compiler converts ??= to a # |
The cpp tagert will break if you don't make this change .___. |
|
Any updates on this? This would be a great feature to have! |
Nothing to explain :)