Skip to content

Commit

Permalink
Fix auto-project-reload looping bug (#1197)
Browse files Browse the repository at this point in the history
  • Loading branch information
m0rkeulv committed Dec 1, 2024
1 parent 8fd41af commit 264d2c8
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 5 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
# Changelog
## 1.5.12
* Bugfix: Fixed issue where Auto-reload project on changes could end up in an infinite loop. (#1197)

## 1.5.12
* Changed: support for intellij 2024.3 & dropping support for 2023.x
* Bugfix: Errors where not navigable when OpenFL project file was outside module dir (Fixed by fstrace4)
Expand Down
4 changes: 2 additions & 2 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ pluginName = Haxe Toolkit Support
pluginRepositoryUrl = https://github.com/HaxeFoundation/intellij-haxe

# SemVer format -> https://semver.org
pluginVersion = 1.5.12
pluginVersion = 1.5.13

# IntelliJ Platform Properties -> https://github.com/JetBrains/gradle-intellij-plugin#intellij-platform-properties
platformType = IU
Expand All @@ -23,7 +23,7 @@ platformDownloadSources = true

# See https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html
# for insight into build numbers and IntelliJ Platform versions.
pluginSinceBuild = 241
pluginSinceBuild = 242
pluginUntilBuild = 243.*

# Plugin Dependencies -> https://plugins.jetbrains.com/docs/intellij/plugin-dependencies.html
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,12 @@ private String getBuildConfigFile(HaxeModuleSettings settings) {

@Override
public boolean isIgnoredSettingsFileEvent(@NotNull String path, @NotNull ExternalSystemSettingsFilesModificationContext context) {
Set<String> files = getSettingsFiles();
if(files.contains(path)){
return false;
// TODO: this "if" is just an attempt to prevent Project reload from marking settings files as changed when reloaded
if(context.getReloadStatus() == ExternalSystemSettingsFilesModificationContext.ReloadStatus.IDLE) {
Set<String> files = getSettingsFiles();
if (files.contains(path)) {
return false;
}
}
return true;
}
Expand Down

0 comments on commit 264d2c8

Please sign in to comment.