Do not annotate uninitialized static final fields if parent type is e…

…xtern.
HaxeFoundation · Feb 4, 2024 · 4a31501 · 4a31501
1 parent 5f3004b
commit 4a31501
Showing 1 changed file with 18 additions and 16 deletions.
diff --git a/src/main/java/com/intellij/plugins/haxe/ide/annotator/semantics/HaxeFieldAnnotator.java b/src/main/java/com/intellij/plugins/haxe/ide/annotator/semantics/HaxeFieldAnnotator.java
@@ -35,28 +35,30 @@ public static void check(final HaxeFieldDeclaration var, final AnnotationHolder
     else {
       if (FINAL_FIELD_IS_INITIALIZED.isEnabled(var)) {
         if (field.isFinal()) {
-          if (!field.hasInitializer()) {
-            if (!isParentInterface(var) && !isParentAnonymousStructure(var)) {
-              if (field.isStatic()) {
-                holder.newAnnotation(HighlightSeverity.ERROR, HaxeBundle.message("haxe.semantic.final.static.var.init", field.getName()))
-                  .range(var)
-                  .create();
+          if (field.getDeclaringClass() == null || !field.getDeclaringClass().isExtern()) {
+            if (!field.hasInitializer()) {
+              if (!isParentInterface(var) && !isParentAnonymousStructure(var)) {
+                if (field.isStatic()) {
+                  holder.newAnnotation(HighlightSeverity.ERROR, HaxeBundle.message("haxe.semantic.final.static.var.init", field.getName()))
+                    .range(var)
+                    .create();
+                }
+                else if (!isFieldInitializedInTheConstructor(field)) {
+                  holder.newAnnotation(HighlightSeverity.ERROR, HaxeBundle.message("haxe.semantic.final.var.init", field.getName()))
+                    .range(var)
+                    .create();
+                }
               }
-              else if (!isFieldInitializedInTheConstructor(field)) {
-                holder.newAnnotation(HighlightSeverity.ERROR, HaxeBundle.message("haxe.semantic.final.var.init", field.getName()))
+            }
+            else {
+              if (isParentInterface(var)) {
+                holder.newAnnotation(HighlightSeverity.ERROR,
+                                     HaxeBundle.message("haxe.semantic.final.static.var.init.interface", field.getName()))
                   .range(var)
                   .create();
               }
             }
           }
-          else {
-            if (isParentInterface(var)) {
-              holder.newAnnotation(HighlightSeverity.ERROR,
-                                   HaxeBundle.message("haxe.semantic.final.static.var.init.interface", field.getName()))
-                .range(var)
-                .create();
-            }
-          }
         }
       }
     }