Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CNAME file with custom domain #24

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

tobil4sk
Copy link
Member

No description provided.

@kLabz kLabz merged commit aa8e036 into HaxeFoundation:master Jul 26, 2024
2 checks passed
@tobil4sk tobil4sk deleted the fix/add-CNAME branch July 26, 2024 11:31
@tobil4sk
Copy link
Member Author

There seems to be conflicting information in the docs about whether this is necessary:

https://docs.github.com/en/pages/configuring-a-custom-domain-for-your-github-pages-site/troubleshooting-custom-domains-and-github-pages#cname-errors

If you are publishing from a custom GitHub Actions workflow, any CNAME file is ignored and is not required.

https://docs.github.com/en/pages/configuring-a-custom-domain-for-your-github-pages-site/managing-a-custom-domain-for-your-github-pages-site#configuring-an-apex-domain

If you are publishing your site with a custom GitHub Actions workflow, no CNAME file is created, so you need to create one manually (containing only a line of text with your custom domain).

I asked to clarify here: github/docs#32930 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants