Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of NextJS to Scan Report Details Page #792

Merged
merged 10 commits into from
Jul 12, 2024

Conversation

AndrewThien
Copy link
Contributor

Changes

This PR implemented NextJS to build the Scan Report Details view. It also added

  • The IsAuthor checking class in permissions.py to check if the user is the author of the current scan report or not.
  • Some tooltips for Save buttons in other forms to clarify the permissions
  • Add a notice to add a new Dataset which has to have a unique name which will relate to finding Scan report details
  • Make the data sent to the PATCH endpoint of updating Scan Report to be an abstract object

Closes #749

Screenshots

  • General view
    Screenshot 2024-07-11 at 12 23 39

Checks

Important: please complete these before merging.

  • Run migrations, if any.
  • Update changelog.md, including migration instructions if any.
  • Run unit tests.

Copy link

github-actions bot commented Jul 11, 2024

Tests Skipped Failures Errors Time
25 1 💤 1 ❌ 0 🔥 4.196s ⏱️

app/api/mapping/permissions.py Outdated Show resolved Hide resolved
@AndrewThien AndrewThien merged commit 1f7a3a4 into master Jul 12, 2024
14 checks passed
@AndrewThien AndrewThien deleted the feat/749/scanreport-details-form branch July 12, 2024 09:00
@AndyRae AndyRae added this to the 2.2.9 milestone Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scan Report Details (edit form)
4 participants