This repository was archived by the owner on Mar 5, 2025. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 29
feat: Allow passing an async function to NuxtAuthHandler #148
Open
joebailey26
wants to merge
3
commits into
Hebilicious:main
Choose a base branch
from
joebailey26:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joebailey26
added a commit
to joebailey26/TV-Shows
that referenced
this pull request
Jan 2, 2024
Hebilicious
reviewed
Jan 4, 2024
Hebilicious
reviewed
Jan 16, 2024
Hebilicious
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I have tried this code:
And I am getting this error:
|
I think your doc is not up to date with the latest changes. The Nuxt module still has old code. Can you please verify? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Resolves #137
Resolves #138
β Type of change
π Description
NuxtAuthHandler
acceptsoptions
andruntimeConfig
in order to build a response as part of the/api/auth/[...]
endpoint.Some adapters, such as D1Adapter, need access to the event in order to connect to the database.
The current solution of passing
options
as anobject
does not expose the event.This PR allows passing
options
as an async function, which takesevent
as its argument. That way, users of this package, can extend it, and add any adapter, or other logic that they want.π Checklist