Skip to content

Commit

Permalink
GEN-681 | Update global banner styles (#2714)
Browse files Browse the repository at this point in the history
<!--
PR title: GRW-123 / Feature / Awesome new thing
-->

## Describe your changes

![Screenshot 2023-07-07 at 13.00.22.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/OgXegTwxM9IeuXHZyw5h/f956960f-b900-4573-a1a0-080a1c82187d/Screenshot%202023-07-07%20at%2013.00.22.png)

- Increase minimum height of notification banner

- Add bottom border to notification banner

<!--
What changes are made?
If there are many changes, a list might be a good format.
If it makes sense, add screenshots and/or screen recordings here.
-->

## Justify why they are needed

- Design updates

## Checklist before requesting a review

- [ ] I have performed a self-review of my code
  • Loading branch information
robinandeer committed Jul 7, 2023
1 parent 0029b5e commit 42bb9bd
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions apps/store/src/components/Banner/Banner.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ const Icon = ({ variant }: { variant: BannerVariant }) => {
}

const Wrapper = styled.div<{ variant: BannerVariant }>(({ variant }) => ({
minHeight: '3rem',
display: 'grid',
// Using grid here to perfect center align banner's content, excluding close button
gridTemplateAreas: `
Expand All @@ -61,6 +62,8 @@ const Wrapper = styled.div<{ variant: BannerVariant }>(({ variant }) => ({
paddingBlock: theme.space.sm,
paddingInline: theme.space.md,
fontSize: theme.fontSizes.xs,

borderBottom: `0.5px solid ${theme.colors.borderTranslucent1}`,
...getVariantStyles(variant),

[mq.lg]: {
Expand Down

2 comments on commit 42bb9bd

@vercel
Copy link

@vercel vercel bot commented on 42bb9bd Jul 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

onboarding – ./apps/onboarding

onboarding-hedvig.vercel.app
racoon-onboarding.vercel.app
onboarding-git-main-hedvig.vercel.app

@vercel
Copy link

@vercel vercel bot commented on 42bb9bd Jul 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.