fix(CostSummary): define applied discount based on cost field #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
guilhermespopolin
force-pushed
the
fix/cost-summary-total-cost
branch
from
e9d3e27
to
dc255d6
Compare
guilhermespopolin
force-pushed
the
fix/cost-summary-total-cost
branch
from
dc255d6
to
0cafd61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Update helper functions used to provide data to
CostSummaryso they rely oncostfield while identifying if there's some discount being applied to your purchase.Before
After
Justify why they are needed
So the Cost summary doesn't look so confusing since it might be some cases where the product you have added into the cart is not covered by the campaign code you've added.
Also going to update the contingency plan by removing these changes after this get's merged.