GEN-637 - feat: added TrustpilotBlock #2711

guilhermespopolin · 2023-07-07T09:00:06Z

Describe your changes

Added a TrustpilotBlock that displays Trustpilot data.

How the whole thing works:

There's a new service - apps/store/src/services/trustpilot/trustpilot.tsx - which fetch that data from Trustpilot API and store it in a Jotai's atom so it can be available through the whole app. We then fetch that data and proper hydrate the atom in the apps/store/src/pages/[[...slug]].tsx and apps/store/src/components/LayoutWithMenu/LayoutWithMenu.tsx files respectively.
TrustpilotBlock then reads that data from the atom and proper display it.

Justify why they are needed

Requested by design/editors

Can be tested here

vercel · 2023-07-07T09:00:08Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
hedvig-dot-com	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 10, 2023 0:52am
onboarding	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 10, 2023 0:52am

guilhermespopolin · 2023-07-07T09:00:12Z

Current dependencies on/for this PR:

main
- PR GEN-637 - feat: added a service to retrieve Trustpilot data #2705
  - PR GEN-637 - feat: make Trustpilot data available globally #2710
    - PR GEN-637 - feat: added TrustpilotBlock #2711 👈

This comment was auto-generated by Graphite.

notion-workspace · 2023-07-07T09:01:17Z

Show rating from Trustpilot on product pages

gustaveen

Nice work! 🙌
On thing to consider is to put the text and url as fields in Storyblok instead. Then we could make a reusable block of it

apps/store/src/blocks/TrustpilotBlock.tsx

guilhermespopolin · 2023-07-07T16:22:15Z

Nice work! 🙌 On thing to consider is to put the text and url as fields in Storyblok instead. Then we could make a reusable block of it

Have update it so we get the link from Storyblok

gustaveen

Awesome! 🙌

robinandeer

Look good!

robinandeer · 2023-07-10T09:02:36Z

apps/store/src/blocks/TrustpilotBlock.tsx

+  paddingBlock: '10rem',
+  paddingInline: '1rem',


Why not use theme?

robinandeer · 2023-07-10T09:02:50Z

apps/store/src/blocks/TrustpilotBlock.tsx

+
+const ScoreText = styled(Text)({
+  lineHeight: '1.32',
+  // Font size tihs high is an edge case. That's why I'm not using Text's 'size' prop


nit: typo "tihs"

guilhermespopolin · 2023-07-10T12:40:58Z

@guilhermespopolin started a stack merge that includes this pull request via Graphite.

guilhermespopolin · 2023-07-10T12:42:36Z

Graphite rebased this pull request as part of a merge.

guilhermespopolin · 2023-07-10T12:43:27Z

@guilhermespopolin merged this pull request with Graphite.

This was referenced Jul 7, 2023

GEN-637 - feat: added a service to retrieve Trustpilot data #2705

Merged

GEN-637 - feat: make Trustpilot data available globally #2710

Merged

guilhermespopolin changed the title ~~feat: added TrustpilotBlock~~ GEN-637 - feat: added TrustpilotBlock Jul 7, 2023

vercel bot deployed to Preview – onboarding July 7, 2023 09:08 View deployment

vercel bot deployed to Preview – hedvig-dot-com July 7, 2023 09:10 View deployment

guilhermespopolin force-pushed the GEN-637/feat/trustpilot-block_split_1 branch from c2481f7 to 4f41042 Compare July 7, 2023 09:21

guilhermespopolin force-pushed the GEN-637/feat/trustpilot-block_split_2 branch from 401cadb to db09879 Compare July 7, 2023 09:21

guilhermespopolin marked this pull request as ready for review July 7, 2023 09:27

guilhermespopolin requested a review from a team as a code owner July 7, 2023 09:27

vercel bot deployed to Preview – onboarding July 7, 2023 09:31 View deployment

vercel bot deployed to Preview – hedvig-dot-com July 7, 2023 09:31 View deployment

gustaveen reviewed Jul 7, 2023

View reviewed changes

apps/store/src/blocks/TrustpilotBlock.tsx Outdated Show resolved Hide resolved

apps/store/src/blocks/TrustpilotBlock.tsx Outdated Show resolved Hide resolved

guilhermespopolin force-pushed the GEN-637/feat/trustpilot-block_split_1 branch from 4f41042 to 727aa26 Compare July 7, 2023 15:51

guilhermespopolin force-pushed the GEN-637/feat/trustpilot-block_split_2 branch from db09879 to b57f5a1 Compare July 7, 2023 15:51

vercel bot deployed to Preview – onboarding July 7, 2023 16:01 View deployment

vercel bot deployed to Preview – hedvig-dot-com July 7, 2023 16:05 View deployment

guilhermespopolin force-pushed the GEN-637/feat/trustpilot-block_split_1 branch from 727aa26 to b33c804 Compare July 7, 2023 16:19

guilhermespopolin force-pushed the GEN-637/feat/trustpilot-block_split_2 branch from b57f5a1 to e7e1901 Compare July 7, 2023 16:19

vercel bot deployed to Preview – hedvig-dot-com July 7, 2023 16:31 View deployment

vercel bot deployed to Preview – onboarding July 7, 2023 16:34 View deployment

guilhermespopolin force-pushed the GEN-637/feat/trustpilot-block_split_1 branch from b33c804 to 465cd12 Compare July 10, 2023 07:39

guilhermespopolin force-pushed the GEN-637/feat/trustpilot-block_split_2 branch from e7e1901 to 9e5aa92 Compare July 10, 2023 07:39

guilhermespopolin requested a review from gustaveen July 10, 2023 07:41

vercel bot deployed to Preview – onboarding July 10, 2023 07:49 View deployment

vercel bot deployed to Preview – hedvig-dot-com July 10, 2023 07:52 View deployment

gustaveen approved these changes Jul 10, 2023

View reviewed changes

guilhermespopolin force-pushed the GEN-637/feat/trustpilot-block_split_1 branch from 465cd12 to 412a50d Compare July 10, 2023 08:10

guilhermespopolin force-pushed the GEN-637/feat/trustpilot-block_split_2 branch from 9e5aa92 to 6009f1b Compare July 10, 2023 08:10

vercel bot deployed to Preview – onboarding July 10, 2023 08:24 View deployment

vercel bot deployed to Preview – hedvig-dot-com July 10, 2023 08:28 View deployment

robinandeer approved these changes Jul 10, 2023

View reviewed changes

guilhermespopolin force-pushed the GEN-637/feat/trustpilot-block_split_1 branch from 412a50d to 6292006 Compare July 10, 2023 09:09

guilhermespopolin force-pushed the GEN-637/feat/trustpilot-block_split_2 branch from 6009f1b to f2a900a Compare July 10, 2023 09:09

vercel bot deployed to Preview – onboarding July 10, 2023 09:20 View deployment

vercel bot deployed to Preview – hedvig-dot-com July 10, 2023 09:24 View deployment

guilhermespopolin force-pushed the GEN-637/feat/trustpilot-block_split_1 branch from 6292006 to b9aa0f1 Compare July 10, 2023 12:01

guilhermespopolin force-pushed the GEN-637/feat/trustpilot-block_split_2 branch from f2a900a to 7bed79e Compare July 10, 2023 12:01

guilhermespopolin force-pushed the GEN-637/feat/trustpilot-block_split_1 branch from b9aa0f1 to 91abec3 Compare July 10, 2023 12:03

guilhermespopolin force-pushed the GEN-637/feat/trustpilot-block_split_2 branch from 7bed79e to e2bf84a Compare July 10, 2023 12:03

vercel bot deployed to Preview – onboarding July 10, 2023 12:14 View deployment

vercel bot deployed to Preview – hedvig-dot-com July 10, 2023 12:16 View deployment

guilhermespopolin force-pushed the GEN-637/feat/trustpilot-block_split_1 branch from 91abec3 to 0e6b172 Compare July 10, 2023 12:41

Base automatically changed from GEN-637/feat/trustpilot-block_split_1 to main July 10, 2023 12:42

feat: added TrustpilotBlock

8b554d4

guilhermespopolin force-pushed the GEN-637/feat/trustpilot-block_split_2 branch from e2bf84a to 8b554d4 Compare July 10, 2023 12:42

guilhermespopolin merged commit 53e94df into main Jul 10, 2023
3 checks passed

guilhermespopolin deleted the GEN-637/feat/trustpilot-block_split_2 branch July 10, 2023 12:43

vercel bot deployed to Preview – onboarding July 10, 2023 12:51 View deployment

vercel bot deployed to Preview – hedvig-dot-com July 10, 2023 12:52 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GEN-637 - feat: added TrustpilotBlock #2711

GEN-637 - feat: added TrustpilotBlock #2711

guilhermespopolin commented Jul 7, 2023 •

edited

Loading

vercel bot commented Jul 7, 2023 •

edited

Loading

guilhermespopolin commented Jul 7, 2023

notion-workspace bot commented Jul 7, 2023

gustaveen left a comment •

edited

Loading

guilhermespopolin commented Jul 7, 2023

gustaveen left a comment

robinandeer left a comment

robinandeer Jul 10, 2023

robinandeer Jul 10, 2023

guilhermespopolin commented Jul 10, 2023

guilhermespopolin commented Jul 10, 2023

guilhermespopolin commented Jul 10, 2023

GEN-637 - feat: added TrustpilotBlock #2711

GEN-637 - feat: added TrustpilotBlock #2711

Conversation

guilhermespopolin commented Jul 7, 2023 • edited Loading

Describe your changes

Justify why they are needed

vercel bot commented Jul 7, 2023 • edited Loading

guilhermespopolin commented Jul 7, 2023

notion-workspace bot commented Jul 7, 2023

gustaveen left a comment • edited Loading

Choose a reason for hiding this comment

guilhermespopolin commented Jul 7, 2023

gustaveen left a comment

Choose a reason for hiding this comment

robinandeer left a comment

Choose a reason for hiding this comment

robinandeer Jul 10, 2023

Choose a reason for hiding this comment

robinandeer Jul 10, 2023

Choose a reason for hiding this comment

guilhermespopolin commented Jul 10, 2023

guilhermespopolin commented Jul 10, 2023

guilhermespopolin commented Jul 10, 2023

guilhermespopolin commented Jul 7, 2023 •

edited

Loading

vercel bot commented Jul 7, 2023 •

edited

Loading

gustaveen left a comment •

edited

Loading