Make input fields translucent #2717
Merged
+100
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
guilhermespopolin
approved these changes
Jul 10, 2023
robinandeer
force-pushed
the
update/translucent-inputs
branch
from
e120630
to
c9bba80
Compare
robinandeer
force-pushed
the
update/translucent-inputs
branch
from
c9bba80
to
765eea1
Compare
robinandeer
force-pushed
the
update/translucent-inputs
branch
from
765eea1
to
0cf568f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Change background color of input fields to "translucent 1"
Update
useHighlightAnimationhook to use JS animations instead of framer motionFix highlight animation for horizontal radio group inputs
Justify why they are needed
I had to switch from framer motion to JS animations becuase framer motion has difficulties tweening colors with alpha values. I also think the new impolementation is slightly easier to understand.
The new solution returns a ref which you attatch to the element you want to animate. In the few cases where we already use the ref, I decided to add a wrapper div around it and animate that (e.g. Combobox).
We want the inputs to be translucent to work better in the price calculator which has a blurred background on mobile.
Checklist before requesting a review