Add Pino for logging to Datadog #421
Conversation
- Enable topLevelAwait in Webpack, needed for Pino logger - Remove server-preload.js, Vercel doesn't run it anyway
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
| @@ -37,7 +36,8 @@ | |||
| "marked": "4.0.18", | |||
| "next": "12.2.2", | |||
| "next-i18next": "^11.0.0", | |||
| "pino": "^7.10.0", | |||
| "pino-datadog": "https://github.com/simonauner/pino-datadog#rename-hostname-to-host", | |||
There was a problem hiding this comment.
Currently running a customized version of pino-datadog because of ovhemert/pino-datadog#89
| @@ -128,7 +128,7 @@ self.addEventListener('fetch', function (event) { | |||
| // At this point, any exception indicates an issue with the original request/response. | |||
| console.error( | |||
| `\ | |||
| [MSW] Caught an exception from the "%s %s" request (%s). This is probably not a problem with Mock Service Worker. There is likely an additional logging output above.`, | |||
| [MSW] Caught an exception from the "%s %s" request (%s). This is probably not a problem with Mock Service Worker. There is likely an additional logging output above.`, | |||
There was a problem hiding this comment.
I accidentally opened this file and saved it, and prettier performed its magic 🤷
There was a problem hiding this comment.
nit: i think you can regenerate with cd apps/store/ && npx msw init ./public && cd -
| version: process.env.NEXT_PUBLIC_DATADOG_VERSION, | ||
| env: process.env.NEXT_PUBLIC_DATADOG_ENV || 'dev', | ||
| env: process.env.NEXT_PUBLIC_DATADOG_ENV || 'local', |
There was a problem hiding this comment.
dev is sometimes referred to as our staging environment, local cannot be misinterpreted as anything other than "running on my machine"?
| // URL will be racoon-onboarding.vercel.app when deployed on Vercel, but empty string when running locally. | ||
| // NEXT_PUBLIC_DATADOG_SERVICE_NAME will be racoon-onboarding, so this is just a way to set a meaningful | ||
| // service name when running locally. | ||
| service: process.env.VERCEL_URL || `${process.env.NEXT_PUBLIC_DATADOG_SERVICE_NAME}.local`, |
There was a problem hiding this comment.
Let's see what process.env.VERCEL_URL translates to when deployed to staging and prod. It might be that it's the machine-name, not the URL, and then this will have to be changed to something else.
| @@ -128,7 +128,7 @@ self.addEventListener('fetch', function (event) { | |||
| // At this point, any exception indicates an issue with the original request/response. | |||
| console.error( | |||
| `\ | |||
| [MSW] Caught an exception from the "%s %s" request (%s). This is probably not a problem with Mock Service Worker. There is likely an additional logging output above.`, | |||
| [MSW] Caught an exception from the "%s %s" request (%s). This is probably not a problem with Mock Service Worker. There is likely an additional logging output above.`, | |||
There was a problem hiding this comment.
nit: i think you can regenerate with cd apps/store/ && npx msw init ./public && cd -
|
Ok, so apparently there is a new Pino version out which doesn't require |
So, my draft PR got a bit messy with all the commits and re-bases #414, starting from a clean slate here.
Describe your changes
Added Pino set up with a log forwarder/transport that sends logs to Datadog.
Had to add
topLevelAwaitallow Pino's init function to work.Removed
server-preload.jswhich doesn't seem to work anymore. In it we monkey-patchedconsole.logand added Datadogs tracing libdd-trace, but it wasn't applied anyway, so might as well remove it to remove confusion about how we log.Justify why they are needed
We already have Datadog set up as an integration in Vercel (https://vercel.com/hedvig/racoon/settings/integrations) which already forwards all Next.js logs to Datadog. This does not cover
console.logs though - all we get is request logs:With Pino in place we have a way to "debug" server code in prod/staging.
Jira issue(s): GRW-1388
Checklist before requesting a review