-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cancelling reactimates #199
Open
PaulJohnson
wants to merge
16
commits into
HeinrichApfelmus:master
Choose a base branch
from
PaulJohnson:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jun 2, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 04f438f - Browse repository at this point
Copy the full SHA 04f438fView commit details
Commits on Jun 3, 2019
-
Prim.addHandler now takes an Output arg.
The Output "o" is passed down the call stack via "buildLater" and will eventually be added to the Network nOutputs ordered bag. It is created here because we need to return a function that removes it from the bag, but the result cannot be passed back to us from the future.
Configuration menu - View commit details
-
Copy full SHA for f715487 - Browse repository at this point
Copy the full SHA f715487View commit details -
Added "other-modules" to tests in cabal
In accordance with Cabal warning message.
Configuration menu - View commit details
-
Copy full SHA for 6cc5480 - Browse repository at this point
Copy the full SHA 6cc5480View commit details -
Compiles an d passes legacy tests.
reactimate1 and reactimate1' are not yet tested.
Configuration menu - View commit details
-
Copy full SHA for d47520a - Browse repository at this point
Copy the full SHA d47520aView commit details
Commits on Jun 4, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 9aa5b82 - Browse repository at this point
Copy the full SHA 9aa5b82View commit details
Commits on Jun 5, 2019
-
Updated comments for reactimate1
The reactimate cancel function calls runStep, which modifies an MVar containing the network state. If this occurs while processing another step (typically from within "execute") then the program will lock up as the re-entrant call tries to read the MVar which is already being modified.
Configuration menu - View commit details
-
Copy full SHA for 1d80ea1 - Browse repository at this point
Copy the full SHA 1d80ea1View commit details
Commits on Jun 16, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 4111c05 - Browse repository at this point
Copy the full SHA 4111c05View commit details
Commits on Jul 1, 2019
-
Comments on pull resuest Cancelling reactimates HeinrichApfelmus#199 Changed type and name for reactimate_ and reactimate_' Introduced new functions runMomentIO_ and getEventNetwork
Configuration menu - View commit details
-
Copy full SHA for 84e20d0 - Browse repository at this point
Copy the full SHA 84e20d0View commit details
Commits on Jul 2, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 0c48703 - Browse repository at this point
Copy the full SHA 0c48703View commit details
Commits on Nov 1, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 948393c - Browse repository at this point
Copy the full SHA 948393cView commit details
Commits on Apr 7, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 0b963f0 - Browse repository at this point
Copy the full SHA 0b963f0View commit details
Commits on Apr 8, 2020
-
Configuration menu - View commit details
-
Copy full SHA for bd1662b - Browse repository at this point
Copy the full SHA bd1662bView commit details
Commits on Jul 2, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 78a92a8 - Browse repository at this point
Copy the full SHA 78a92a8View commit details
Commits on Jul 28, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ec63a73 - Browse repository at this point
Copy the full SHA ec63a73View commit details
Commits on Aug 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 684dd9e - Browse repository at this point
Copy the full SHA 684dd9eView commit details
Commits on Feb 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for bf08809 - Browse repository at this point
Copy the full SHA bf08809View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.