Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalise compile, actuate and pause to MonadIO #226

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Generalise compile, actuate and pause to MonadIO #226

wants to merge 3 commits into from

Conversation

ocharles
Copy link
Collaborator

No description provided.

mitchellwrosen
mitchellwrosen approved these changes Sep 16, 2021
View reviewed changes
Copy link
Collaborator

@mitchellwrosen mitchellwrosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vagarenko
Copy link
Contributor

vagarenko commented Sep 16, 2021 •
edited
Loading

Perhaps lift pause :: EventNetwork -> IO () too?

@ocharles
Copy link
Collaborator Author

Good shout @vagarenko - I think we should do all of these or none of them, so I'll add pause into this.

@ocharles ocharles changed the title Generalise compile and actuate to MonadIO Generalise compile, actuate and pause to MonadIO Sep 16, 2021
@HeinrichApfelmus
Copy link
Owner

Alas, I'm not entirely sold on the introduction of MonadIO, as it makes the types more complicated.

I have made a comment in the related pull request #225 (comment) . To avoid duplication, I propose that we discuss this issue there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchellwrosen mitchellwrosen mitchellwrosen approved these changes

@HeinrichApfelmus HeinrichApfelmus Awaiting requested review from HeinrichApfelmus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ocharles @vagarenko @HeinrichApfelmus @mitchellwrosen