support https (wss) #210
Open
support https (wss) #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think that that the web server supports https at the moment. Would be nice, though. |
|
Sorry, I didn't think about that. You are probably right. But if the server runs behind a load balancer or reverse proxy which cares for the ssl and forwards http requests https can be used but only if wss is used instead of ws. |
addap
added a commit
to addap/initiative-counter
that referenced
this pull request
Dec 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using https secure websockets (wss) have to be used.
Also the slice(5) doesn't work properly for https as it would include the colon.