Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement window resize event #221

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

implement window resize event #221

wants to merge 3 commits into from

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Jul 9, 2018 •
edited
Loading

This is my first attempt at providing an event that informs about changes of (browser) window size (Issue #219).

Since this is a global (not-element specific) event I have my doubts about

  • improving signature (to Window -> Event ...?)
  • how to implement that (I'd need unsafeRunUI because of getBody :: Window -> UI Element
  • ensure that there is at most one such event around?
  • Is the FIXME in

    threepenny-gui/src/Reactive/Threepenny.hs

    Line 128 in f719c1e

    -- FIXME: Unregistering event handlers does not work yet.
    still valid?
  • Is the haddocks explanation enough?

@ggreif
Copy link
Contributor Author

ggreif commented Nov 14, 2018

Not sure yet what the best approach is. Don't merge yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ggreif