Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for consistency of fresnels equations #124

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

VincentLatko
Copy link

No description provided.

@simbilod
Copy link
Contributor

Nice! PML seems a bit thin (2-3 mesh points)

image

@HelgeGehring
Copy link
Owner

We might want also to start with a lower resolution, most of the examples in the docs are resolutionwise rather at low resolution to make them run fast (for understanding things) - once we want high precision we can always increase the resolution

@HelgeGehring
Copy link
Owner

Could you run

pip install pre-commit
pre-commit install
pre-commit run --all

that will format the code (and do it after installing always when you commit)
after that I'm happy to accept the PR :)

    - Increase thickness of PMLS
    - Format code using pre-commit
@VincentLatko
Copy link
Author

I pushed the new version. Also increased the PML thickness. I hope this is better.

@HelgeGehring
Copy link
Owner

Looks good now!
Probably, now the resolution is a bit too low. We should aim at something like 10 elements / wavelength. That'll probably give a good runtime while representing the physics correctly.
But that's something we can co-optimize as soon as we have the simulation getting started :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants