Sessions Feedback #2730
Open
Sessions Feedback #2730
+10,469
−9,204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@chitalian @maamalama I feel like this is good enough to merge now, filters is i think big enough to create a separate pr on, and it will probably take longer than i expected 🥲 |
|
3f8404f and 199ecca implements session feedback
Screen.Recording.2024-10-09.at.11.09.24.am.mov |
chitalian
reviewed
Oct 9, 2024
Comment on lines
+373
to
+379
| const query = ` | ||
| SELECT request_id | ||
| FROM request_response_rmt | ||
| WHERE properties['Helicone-Session-Id'] = '${sessionId}' | ||
| ORDER BY request_created_at ASC | ||
| LIMIT 1 | ||
| `; |
There was a problem hiding this comment.
Can you also select for the organzation_id = the user org?
There was a problem hiding this comment.
Actually can we select from postgres instead? We have better indexes on the JSONB column for custom properties and clickhouse is notoriously bad at point queries
chitalian
reviewed
Oct 9, 2024
| LIMIT 1 | ||
| `; | ||
|
|
||
| console.log({ query }); |
There was a problem hiding this comment.
and the other console logs below too
…2712) * fix(cache): ensure cache tabs hold selected state * fix(11149993052): auto linting --------- Co-authored-by: use-tusk[bot] <144006087+use-tusk[bot]@users.noreply.github.com> Co-authored-by: Justin Torre <[email protected]>
…dal (#2736) Co-authored-by: use-tusk[bot] <144006087+use-tusk[bot]@users.noreply.github.com>
Co-authored-by: use-tusk[bot] <144006087+use-tusk[bot]@users.noreply.github.com>
* speed up jawn dev server * Remove time logging in genTypes.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-10-08.at.4.03.13.pm.mov