Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-1147] Fix icon spacing in the Create Organization modal #2736

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

use-tusk[bot]
Copy link
Contributor

@use-tusk use-tusk bot commented Oct 8, 2024

This PR addresses the issue of overlapping icons in the 'Create New Organization' modal. The changes involve updating the layout from a flexbox to a grid system, ensuring proper spacing between icons.

The grid layout will distribute the icons evenly across the available space, preventing overlap. Each icon will remain centered within its respective grid cell.


Automated Browser Testing (as of commit 3f421bc)

Result: Success ✅

Success image

Assertion Result: The icons at the bottom of the 'Create New Organization' modal are correctly spaced and not overlapping. The assertion passed.

Success Image 0-0


Tips:

  • Make sure to test changes before merging.
  • Submit a "Request Changes" review to address nits. If major changes are needed, retry the issue from the Tusk app with additional context.
  • Close this PR with a comment if it's obviously incorrect. This will improve my future PRs.
  • Go to the Tusk activity logs or issue to see more details.

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
helicone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 3:12am
helicone-bifrost ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 3:12am
helicone-eu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 3:12am

@use-tusk use-tusk bot changed the title Tusk WIP - Can you fix the spacing on creating a new org? [ENG-1147] Fix icon spacing in the Create Organization modal Oct 8, 2024
@use-tusk use-tusk bot marked this pull request as ready for review October 8, 2024 03:19
@chitalian chitalian merged commit 327ad4f into main Oct 8, 2024
10 checks passed
@chitalian chitalian deleted the tusk-ENG-1147-fix-icon-spacing-100820240308 branch October 8, 2024 14:48
kavinvalli pushed a commit that referenced this pull request Oct 8, 2024
…dal (#2736)

Co-authored-by: use-tusk[bot] <144006087+use-tusk[bot]@users.noreply.github.com>
kavinvalli pushed a commit that referenced this pull request Oct 10, 2024
…dal (#2736)

Co-authored-by: use-tusk[bot] <144006087+use-tusk[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant