Update the warning banner styling #2757

use-tusk · 2024-10-10T16:29:04Z

This PR updates the styling of the warning banner on the request page. The changes include:

Changing the background color to sky-500 using bg-sky-500.
Setting the text color to white (#FFFFFF) using text-white.
Adjusting the font size to 13px using text-[13px].
Ensuring proper layout with flex justify-between items-center and adding padding with p-4.
Updating the close button styling to match the new color scheme with text-white and hover:text-gray-200.

These updates provide a clearer and more visually appealing warning banner to users.

Tips:

Make sure to test changes before merging.
Submit a "Request Changes" review to address nits. If major changes are needed, retry the issue from the Tusk app with additional context.
Close this PR with a comment if it's obviously incorrect. This will improve my future PRs.
Go to the Tusk activity logs to see more details.

vercel · 2024-10-10T16:29:07Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
helicone	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 11, 2024 6:15am
helicone-bifrost	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 11, 2024 6:15am
helicone-eu	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 11, 2024 6:15am

LinaLam · 2024-10-11T00:35:19Z

web/components/templates/requestsV2/requestsPageV2.tsx

@@ -742,8 +742,8 @@ const RequestsPageV2 = (props: RequestsPageV2Props) => {
    <>
      <div className="h-screen flex flex-col">
        {requestWithoutStream && !isWarningHidden && (
-          <div className="alert alert-warning flex justify-between items-center">
-            <p className="text-yellow-800">
+          <div className="bg-sky-500 text-white text-[13px] flex justify-between items-center p-4">


change to "bg-sky-200" please

LinaLam · 2024-10-11T00:35:49Z

web/components/templates/requestsV2/requestsPageV2.tsx

@@ -742,8 +742,8 @@ const RequestsPageV2 = (props: RequestsPageV2Props) => {
    <>
      <div className="h-screen flex flex-col">
        {requestWithoutStream && !isWarningHidden && (
-          <div className="alert alert-warning flex justify-between items-center">
-            <p className="text-yellow-800">
+          <div className="bg-sky-500 text-white text-[13px] flex justify-between items-center p-4">


Can you reduce the padding to p-2 instead

use-tusk · 2024-10-11T00:36:34Z

Addressing your review. View activity logs for details.

use-tusk · 2024-10-11T00:41:55Z

@LinaLam I've addressed your review. Add another review if minor changes are needed. If major changes are needed, retry the issue from the Tusk app with additional context.

LinaLam · 2024-10-11T05:39:47Z

web/components/templates/requestsV2/requestsPageV2.tsx

@@ -742,8 +742,8 @@ const RequestsPageV2 = (props: RequestsPageV2Props) => {
    <>
      <div className="h-screen flex flex-col">
        {requestWithoutStream && !isWarningHidden && (
-          <div className="alert alert-warning flex justify-between items-center">
-            <p className="text-yellow-800">
+          <div className="bg-sky-200 text-white text-[13px] flex justify-between items-center p-2">


can you make it bg-sky-400 instead?

use-tusk · 2024-10-11T05:41:20Z

Addressing your review. View activity logs for details.

use-tusk · 2024-10-11T05:47:01Z

@LinaLam I've addressed your review. Add another review if minor changes are needed. If major changes are needed, retry the issue from the Tusk app with additional context.

LinaLam · 2024-10-11T06:06:53Z

web/components/templates/requestsV2/requestsPageV2.tsx

@@ -742,8 +742,8 @@ const RequestsPageV2 = (props: RequestsPageV2Props) => {
    <>
      <div className="h-screen flex flex-col">
        {requestWithoutStream && !isWarningHidden && (
-          <div className="alert alert-warning flex justify-between items-center">
-            <p className="text-yellow-800">
+          <div className="bg-sky-400 text-white text-[13px] flex justify-between items-center p-2">


make it bg-sky-400 please

LinaLam · 2024-10-11T06:07:59Z

web/components/templates/requestsV2/requestsPageV2.tsx

-          <div className="alert alert-warning flex justify-between items-center">
-            <p className="text-yellow-800">
+          <div className="bg-sky-400 text-white text-[13px] flex justify-between items-center p-2">
+            <p>
              We are unable to calculate your cost accurately because the
              &#39;stream_usage&#39; option is not included in your message.
              Please refer to{" "}


can you make sure the link after called "this documentation" is in white?

use-tusk · 2024-10-11T06:08:10Z

Addressing your review. View activity logs for details.

use-tusk · 2024-10-11T06:15:44Z

@LinaLam I've addressed your review. Add another review if minor changes are needed. If major changes are needed, retry the issue from the Tusk app with additional context.

improvement(requests): update warning banner styling

af45cca

LinaLam requested changes Oct 11, 2024

View reviewed changes

fix: address review from LinaLam

c374707

vercel bot deployed to Preview – helicone-bifrost October 11, 2024 00:41 View deployment

merge main into tusk-update-warning-banner-101020241625

6872fce

use-tusk bot requested a review from LinaLam October 11, 2024 00:41

vercel bot deployed to Preview – helicone-bifrost October 11, 2024 00:45 View deployment

vercel bot deployed to Preview – helicone-eu October 11, 2024 00:47 View deployment

vercel bot deployed to Preview – helicone October 11, 2024 00:47 View deployment

LinaLam requested changes Oct 11, 2024

View reviewed changes

fix: address review from LinaLam

ddf278a

vercel bot deployed to Preview – helicone-eu October 11, 2024 05:45 View deployment

vercel bot deployed to Preview – helicone October 11, 2024 05:46 View deployment

vercel bot deployed to Preview – helicone-bifrost October 11, 2024 05:46 View deployment

use-tusk bot requested a review from LinaLam October 11, 2024 05:47

LinaLam requested changes Oct 11, 2024

View reviewed changes

fix: address review from LinaLam

8f0a114

vercel bot deployed to Preview – helicone-bifrost October 11, 2024 06:13 View deployment

vercel bot deployed to Preview – helicone October 11, 2024 06:14 View deployment

vercel bot deployed to Preview – helicone-eu October 11, 2024 06:15 View deployment

use-tusk bot requested a review from LinaLam October 11, 2024 06:15

LinaLam approved these changes Oct 11, 2024

View reviewed changes

LinaLam merged commit e378416 into main Oct 11, 2024
9 of 10 checks passed

LinaLam deleted the tusk-update-warning-banner-101020241625 branch October 11, 2024 16:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the warning banner styling #2757

Update the warning banner styling #2757

use-tusk bot commented Oct 10, 2024

vercel bot commented Oct 10, 2024 •

edited

Loading

LinaLam Oct 11, 2024

LinaLam Oct 11, 2024

use-tusk bot commented Oct 11, 2024

use-tusk bot commented Oct 11, 2024

LinaLam Oct 11, 2024

use-tusk bot commented Oct 11, 2024

use-tusk bot commented Oct 11, 2024

LinaLam Oct 11, 2024

LinaLam Oct 11, 2024

use-tusk bot commented Oct 11, 2024

use-tusk bot commented Oct 11, 2024

Update the warning banner styling #2757

Update the warning banner styling #2757

Conversation

use-tusk bot commented Oct 10, 2024

vercel bot commented Oct 10, 2024 • edited Loading

LinaLam Oct 11, 2024

Choose a reason for hiding this comment

LinaLam Oct 11, 2024

Choose a reason for hiding this comment

use-tusk bot commented Oct 11, 2024

use-tusk bot commented Oct 11, 2024

LinaLam Oct 11, 2024

Choose a reason for hiding this comment

use-tusk bot commented Oct 11, 2024

use-tusk bot commented Oct 11, 2024

LinaLam Oct 11, 2024

Choose a reason for hiding this comment

LinaLam Oct 11, 2024

Choose a reason for hiding this comment

use-tusk bot commented Oct 11, 2024

use-tusk bot commented Oct 11, 2024

vercel bot commented Oct 10, 2024 •

edited

Loading