Handle async middleware #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htuzel
approved these changes
Feb 9, 2023
yannbriancon
force-pushed
the
handle-async-middleware
branch
from
7bd2ffa
to
a77995c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behaviour
Middlewares are called in a try catch to handle errors.
This works as expected for synchronous middlewares but asynchronous middlewares errors are not caught.
Solution
Add an await to the middleware call.
No changes expected for synchronous middlewares.
Temporary solution
This branch was deployed to https://www.npmjs.com/package/express-ws-await while merging this MR.