Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved double names, renamed imported library to expressWsLib #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Resolved double names, renamed imported library to expressWsLib #66

wants to merge 1 commit into from

Conversation

Brampage
Copy link

No description provided.

@joepie91
Copy link
Collaborator

Thanks for your PR!

This is indeed an issue that needs to be solved, but I think that renaming the instance to expressWsInstance or such and leaving the library itself as expressWs would be a better way to solve it - this would be in line with the convention in Node.js to store a require()d library in a variable named after itself.

Thoughts?

@joepie91 joepie91 self-assigned this Mar 17, 2017
@Brampage
Copy link
Author

You're welcome :)
Yes, that sounds better to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joepie91 joepie91

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Brampage @joepie91