Cmake #3
Open
Cmake #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally we should rename this file, but for now I'm not willing to take that on
Previously, `get_absfilename()` was replacing '/..' for '/', without deleting the parent directory string.
Add LGTM code quality badges
Clarify that the usual usage pattern for icecc (adding its symlinks to $PATH) should not be followed when using ccache's own symlinks.
Recent versions of valgrind abort with error if they cannot write to --log-file, and this seems to cause problems with chroot-ed processes. So redirect to a socket and valgrind-listener.
- The tilde doesn't need to be escaped in markdown. - placing some strings into "code" format by means of backticks.
According https://gcc.gnu.org/onlinedocs/gcc/Instrumentation-Options.html --coverage option is a synonym for -fprofile-arcs -ftest-coverage.
Or rather force it, because all(?) compilers in use support it, or even newer.
Remember the total size of an unpacked environment tarball instead of computing it on removal, because if something external removes something from it (e.g. an automatic system cleanup or /var/cache), then the reported sum will be smaller, so the daemon will think the cache takes up more than it does.
It seems that -W (which IIRC is the old name for -Wextra) either doesn't work anymore or it doesn't work with Clang.
… headers are properly installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some of the cmake install targets, not complete yet.
In addition a fix in finding libcap-ng.