SC 2776: UI component input component phone #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move Input component into molecules Add Menu component Add PhoneInput component
DmytroLaikov
requested review from
AndrewZinko,
anhromovyi,
bnwebdev,
medreres and
dmytroipatov
and removed request for
a team
|
This pull request has been linked to Shortcut Story #2776: UI Component: Input component (Phone). |
medreres
suggested changes
Oct 25, 2023
packages/ui/src/components/molecules/Input/components/InputField.tsx
Outdated
Show resolved
Hide resolved
...i/src/components/organisms/PhoneInput/components/components/components/SelectCallingCode.tsx
Show resolved
Hide resolved
bnwebdev
suggested changes
Oct 25, 2023
packages/ui/src/components/organisms/PhoneInput/components/components/types.ts
Outdated
Show resolved
Hide resolved
packages/ui/src/components/organisms/PhoneInput/components/helpers/codeWithPrefix.ts
Outdated
Show resolved
Hide resolved
packages/ui/src/components/organisms/PhoneInput/components/hooks/useSelectCountry.ts
Outdated
Show resolved
Hide resolved
packages/ui/src/components/organisms/PhoneInput/components/hooks/useSelectCountry.ts
Outdated
Show resolved
Hide resolved
|
@DmytroLaikov There are no red borders for error state on the record. Is it the right behavior? |
dmytroipatov
suggested changes
Oct 25, 2023
packages/ui/src/components/organisms/PhoneInput/components/components/types.ts
Outdated
Show resolved
Hide resolved
packages/ui/src/components/organisms/PhoneInput/components/helpers/codeWithPrefix.ts
Outdated
Show resolved
Hide resolved
medreres
previously approved these changes
Oct 25, 2023
bnwebdev
suggested changes
Oct 25, 2023
bnwebdev
previously approved these changes
Oct 25, 2023
dmytroipatov
previously approved these changes
Oct 25, 2023
AndrewZinko
previously approved these changes
Oct 25, 2023
medreres
suggested changes
Oct 31, 2023
AndrewZinko
suggested changes
Oct 31, 2023
AndrewZinko
previously approved these changes
Oct 31, 2023
medreres
previously approved these changes
Oct 31, 2023
anhromovyi-sysgears
suggested changes
Oct 31, 2023
packages/ui/src/components/organisms/PhoneInput/components/hooks/index.ts
Outdated
Show resolved
Hide resolved
packages/ui/src/components/organisms/PhoneInput/components/helpers/index.ts
Outdated
Show resolved
Hide resolved
packages/ui/src/components/molecules/Input/components/InputHelper.tsx
Outdated
Show resolved
Hide resolved
DmytroLaikov
dismissed stale reviews from medreres and AndrewZinko
via
0b72ae4
anhromovyi-sysgears
approved these changes
Nov 1, 2023
dmytroipatov
approved these changes
Nov 1, 2023
AndrewZinko
approved these changes
Nov 1, 2023
anhromovyi-sysgears
deleted the
dmytrolaikov/sc-2776/ui-component-input-component-phone
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
Why Are We Making This Change?
UI component for phone input is needed
How Is The Codebase Changing?
Added UI component for phone input with country and calling code selector
Added Menu component (it was needed for changing country calling code)
Added theme styles for:
Related Tasks
Implement phone-based login
UI Component: Input component (Dropdown)
https://www.loom.com/share/cbd341f1d88d4b13ac847e58a4eaa589?sid=7132f329-c247-40ae-bb9e-e0df43206ca5
Additional Notes
Add @callstack/react-theme-provider because of xcarpentier/react-native-country-picker-modal#496