Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cairo1 module --- SLR prediction model #22

Merged
merged 78 commits into from
Jun 5, 2024
Merged

cairo1 module --- SLR prediction model #22

merged 78 commits into from
Jun 5, 2024

Conversation

Okm165
Copy link
Collaborator

@Okm165 Okm165 commented Apr 29, 2024 •
edited
Loading

This PR aims to create a cairo1 module with simple linear regression least squares method prediction model

@Okm165 Okm165 added the enhancement New feature or request label Apr 29, 2024
@Okm165 Okm165 self-assigned this Apr 29, 2024
@Okm165 Okm165 marked this pull request as draft April 29, 2024 07:14
@Okm165
Copy link
Collaborator Author

Okm165 commented May 2, 2024 •
edited
Loading

Running sierra with loop or recursion seems to fail, issue submitted lambdaclass/cairo-vm#1745

@Okm165 Okm165 changed the title cairo1 interop module cairo1 interop module --- cairo1 SLR model in HDP May 2, 2024
@Okm165 Okm165 changed the title cairo1 interop module --- cairo1 SLR model in HDP cairo1 module --- SLR prediction model in HDP May 2, 2024
@Okm165
Copy link
Collaborator Author

Okm165 commented May 29, 2024

I changed back to Fraction type impl because we need u256 support all checks passing now

@Okm165 Okm165 marked this pull request as ready for review May 29, 2024 14:24
@Okm165 Okm165 assigned Okm165 and unassigned Okm165 May 29, 2024
@rkdud007
Copy link
Member

let's add some documentation on readme before merge about :

  • how Cairo1 module can be run on Cairo 0 cairo vm with bootloader stuff. @Okm165
  • developer guide about how to setup cairo environment with python package stuff @rkdud007

@rkdud007 rkdud007 mentioned this pull request May 30, 2024
Merged
@Okm165 Okm165 added the documentation Improvements or additions to documentation label May 30, 2024
@Okm165 Okm165 merged commit 7898d04 into main Jun 5, 2024
1 check passed
@Okm165 Okm165 deleted the cairo1_module branch August 6, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Okm165 Okm165

Labels
Cairo0 Cairo1 documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Okm165 @rkdud007