-
-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render SelectFields as MUI Selects #4059
base: main
Are you sure you want to change the base?
Conversation
This renders most drop-down selection prompts inside Heroic. In turn, these dropdowns now work inside the Gamescope session. Current issues: - Controller navigation does not work, hitting "Down" opens the dropdown, with no way to navigate further down to other components - There is a black box in the top-left of the component, where the label should be
MUI CSS class names are not stable, they cannot be used like this
I prefer to use this over CSS rules in a separate file since it can sometimes be unclear where "the magic happens". Having layout and style together is clearer IMO
This will definitely break things, but it makes selects work
253e014
to
7746476
Compare
Navigating "over" selects now works This is done by simulating Tab/Shift-Tab key presses when pressing the respective buttons while focussing a MUI select element I've gone ahead and removed our home-grown `GamepadInputEvent` type, as it's just a lesser version of Electron's input events
This makes dialogs closeable with the back button again
Restoring the focussed element on dialog close is already handled by MUI, we don't need this code ourselves Moving focus on dialog open *should* work automatically as well, however it doesn't. I've tried various methods with element properties and JS, nothing seems to work. As a band-aid fix for now, we simulate 1-2 tab presses to focus the dialog content
218a328
to
e88d290
Compare
Closing selects with the B/Circle button
MUI treats an empty value as "don't show anything selected", while native selects show the first option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I left a comment about an accessibility feature that is not working with the new dialogs
f327b2a
to
201eb19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been testing a bit more, I found 1 issue and two small things: one small thing is the the second small thing is that the controller hints (the instructions of what each button does at the bottom of the screen) shows incorrect hints for dropdowns, it thinks it's the context menu of library cards and it shows now the issue is that, when using a controller to navigate the UI (or a keyboard), you can get
a smaller dialog doesn't have this problem:
|
This renders most drop-down selection prompts inside Heroic. In turn, these dropdowns now work inside the Gamescope session.
Current issues:
Use the following Checklist if you have changed something on the Backend or Frontend: